Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e ui: allow to choose elemental ui version #665

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Feb 14, 2023

By default, we always install the latest elemental-ui version, it could be useful to choose installing another versions like the latest stable for instance.

Verification runs:
Test where I have specified version 1.0.0
Test with default value (latest) This one failed but for another reason (new UI)
I also added the version used in the summary:

UI Test:

image

CLI Test:

image

@juadk juadk self-assigned this Feb 14, 2023
@juadk juadk force-pushed the choose_elemental_ui_version branch 2 times, most recently from 2bca595 to 413b265 Compare February 14, 2023 12:54
@juadk juadk marked this pull request as ready for review February 14, 2023 12:54
@juadk juadk force-pushed the choose_elemental_ui_version branch 3 times, most recently from 69a31b0 to d12fd17 Compare February 14, 2023 13:45
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a small issue, otherwise looks good.

@juadk juadk force-pushed the choose_elemental_ui_version branch from d12fd17 to a2bd26b Compare February 14, 2023 13:58
@juadk juadk requested a review from ldevulder February 14, 2023 13:58
@juadk juadk enabled auto-merge (rebase) February 14, 2023 14:00
@juadk juadk merged commit c6d84ad into main Feb 14, 2023
@juadk juadk deleted the choose_elemental_ui_version branch February 14, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants