Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use wget in elemental-iso-add-registration #641

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Don't use wget in elemental-iso-add-registration #641

merged 2 commits into from
Jun 30, 2023

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jan 30, 2023

The rationale behind this change is that wget is not shipped with SLE Micro while curl is.

@davidcassany
Copy link
Contributor

The rationale behind this change is that wget is not shipped with SLE Micro while curl is.

Thanks! 👍

fgiudici
fgiudici requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
One little change required :-)

@cbosdo
Don't use wget in elemental-iso-add-registration
6c4e48f 
The rationale behind this change is that wget is not shipped with SLE
Micro while curl is.
fgiudici
fgiudici approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@fgiudici fgiudici enabled auto-merge (squash) January 30, 2023 17:15
@ldevulder
Copy link
Contributor

What I don't like is that curl doesn't do retry and we have sporadic download issue with opensuse.org regularly...

@kkaempf kkaempf requested a review from a team as a code owner June 30, 2023 10:52
@fgiudici fgiudici merged commit 563f627 into rancher:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

@fgiudici fgiudici fgiudici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbosdo @davidcassany @ldevulder @fgiudici @kkaempf