Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redirect to new URL on all pages #551

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

nunix
Copy link
Contributor

@nunix nunix commented Dec 2, 2022

Redirect configuration:
from: rancher.github.io/elemental/*
to: elemental.docs.rancher.com

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com

Redirect configuration:
from: rancher.github.io/elemental/*
to: elemental.docs.rancher.com

Signed-off-by: Nuno do Carmo <nuno.carmo@suse.com>
@kkaempf
Copy link
Contributor

kkaempf commented Dec 2, 2022

20 files changed ? Really ?

There should be a simpler way ...

imho we should just redirect the toplevel like we did it for os2

@nunix
Copy link
Contributor Author

nunix commented Dec 2, 2022

20 files changed ? Really ?

There should be a simpler way ...

imho we should just redirect the toplevel like we did it for os2

I wanted to do it too, however while mkdocs allows it on its config, Docusaurus doesn't. So right now, to ensure "all" pages redirect to the new URL, this is the only way, other else we can replace the /docs content with only an index file that does the redirect, but if someone had a page in favorite, then it will throw a 404.

Also, this is an intermediate step and in few months, we'll remove the /docs directory from this repo (to keep it clean).

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well ...

Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Itxaka Itxaka enabled auto-merge (squash) December 2, 2022 10:29
@Itxaka Itxaka merged commit e5055fe into rancher:main Dec 2, 2022
@nunix nunix deleted the redirect-new-docs-url branch December 27, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants