Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set transient recovery hostname #1236

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 22, 2024

Only setting hostname for recovery using yip overwrites the hostname and uses "recovery" also for active mode.

This commits sets a transient hostname when booting into recovery, hopefully allowing active hostname to not be overwritten.

@frelon frelon requested a review from a team as a code owner February 22, 2024 12:40
@frelon frelon force-pushed the recovery-hostname branch 2 times, most recently from 372ab7d to bba0929 Compare February 23, 2024 12:40
@frelon frelon enabled auto-merge (rebase) February 23, 2024 12:40
Only setting hostname for recovery using yip overwrites the hostname and
uses "recovery" also for active mode.

This commits sets a transient hostname when booting into recovery,
hopefully allowing active hostname to not be overwritten.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon linked an issue Feb 26, 2024 that may be closed by this pull request
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@frelon frelon merged commit 0041ff0 into rancher:main Feb 26, 2024
2 of 3 checks passed
@frelon frelon deleted the recovery-hostname branch February 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booting into recovery sets static hostname
2 participants