Make ibs happy - provide BuildName in Dockerfiles #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
mbologna
approved these changes
Feb 6, 2024
mbologna
approved these changes
Feb 6, 2024
davidcassany
reviewed
Feb 6, 2024
| #!BuildName: SLE-Micro-base-container | ||
| #!BuildTag: suse/sle-micro/sle-micro-base-container-%%SLEMICRO_VERSION%%:latest | ||
| #!BuildTag: suse/sle-micro/sle-micro-base-container-%%SLEMICRO_VERSION%%:%VERSION% | ||
| #!BuildTag: suse/sle-micro/sle-micro-base-container-%%SLEMICRO_VERSION%%:%VERSION%-%RELEASE% |
There was a problem hiding this comment.
Is there any specific reason to drop the / from the tag. This is likely to cause issues in the registry as these paths are going through some path filters to determine its accessibility.
There was a problem hiding this comment.
Not sure what you're refering to exactly 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBS has some rules in place when submitting to the
SUSE:namespace. One is that Dockerfiles must provide a#!BuildNamematching the IBS project (aka "package") name.This PR also adapts the BuildTags a bit, but these tags are not final yet.