Don't set the hostname #1171
Merged
Don't set the hostname #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
c39d338 to
363c1d3
Compare
363c1d3 to
d059518
Compare
|
Patch changed: we keep creating the symlink and we set a transient hostname. |
frelon
approved these changes
Jan 31, 2024
If the (static) hostname is not set, we used to set a rancher-${RANDOM}
one. This anyway prevents DHCP to serve a transient hostname.
In Elemental, at registration time, the hostname is recorded as the
MachineInventory name and from that point onwards it could not be
changed. It will be enforced as the static hostname during the k3s/RKE2
provisioning.
Since we do registration just after the ISO boot, in order to use the
DHCP provided hostname, we should allow the transient name to be set by
the dhcp client (which happens only if the static hostname is not
set) and then take advantage of the new templating value:
${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Let's anyway set the racher-${RANDOM} hostname but as a transient one
and before the network stage (so it may be replaced by the DHCP provided
one).
This is a change in behavior: on Elemental booting (before provisioning)
if a hostname has not been set and DHCP provides one, the DHCP hostname
takes precedence over the rancher-${RANDOM} one.
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
9719de1 to
13eb4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the (static) hostname is not set, we used to set a rancher-${RANDOM} one. This anyway prevents DHCP to serve a transient hostname. In Elemental, at registration time, the hostname is recorded as the MachineInventory name and from that point onwards it could not be changed. It will be enforced as the static hostname during the k3s/RKE2 provisioning.
Since we do registration just after the ISO boot, in order to use the DHCP provided hostname, we should allow the transient name to be set by the dhcp client (which happens only if the static hostname is not set) and then take advantage of the new templating value: ${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Let's anyway set the racher-${RANDOM} hostname but as a transient one and before the network stage (so it may be replaced by the DHCP provided one).
This is a change in behavior: on Elemental booting (before provisioning) if a hostname has not been set and DHCP provides one, the DHCP hostname takes precedence over the rancher-${RANDOM} one.
Fixes #1172