ci/cli: fix sporadic error in WaitCluster #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juadk
approved these changes
Nov 2, 2023
Not a good idea to check error value inside an `Eventually`, better to loop until the condition is met or wait for timeout. Signed-off-by: Loic Devulder <ldevulder@suse.com>
cfc0fcd to
e54725a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a good idea to check error value inside an
Eventually, better to loop until the condition is met or wait for timeout.Verification run:
NOTE: VR is failing for another issue not related to this PR. The code changed here has been validated in the master node deployment.