Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/ui: improve ui upgrade tests #1068

Merged
merged 1 commit into from
Oct 30, 2023
Merged

ci/ui: improve ui upgrade tests #1068

merged 1 commit into from
Oct 30, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Oct 27, 2023 •
edited
Loading

  • no need to add extra channel anymore
  • remove the older/ugly workaround in upgrade test
  • bump elemental stable version

Verification runs

UI-K3s-OS-Upgrade-RM_Stable ✅
UI-K3s-OS-Upgrade-RM_head_2.7 ✅
UI-RKE2-OS-Upgrade-RM_head_2.7 ✅
UI-K3s-OS-Upgrade-RM_head_2.8 ✅
UI-RKE2-OS-Upgrade-RM_head_2.8 ✅

@juadk juadk added the kind/QA label Oct 27, 2023
@juadk juadk self-assigned this Oct 27, 2023
@juadk juadk force-pushed the improve_upgrade_ui_tests branch 3 times, most recently from c0b3da7 to f53df85 Compare October 27, 2023 14:18
@ldevulder ldevulder mentioned this pull request Oct 27, 2023
Merged
@juadk juadk force-pushed the improve_upgrade_ui_tests branch from f53df85 to 34120d8 Compare October 27, 2023 16:14
@juadk juadk marked this pull request as ready for review October 27, 2023 16:15
@juadk juadk requested a review from a team as a code owner October 27, 2023 16:15
@juadk juadk force-pushed the improve_upgrade_ui_tests branch 2 times, most recently from 9d9d085 to 10a2163 Compare October 27, 2023 16:20
ldevulder
ldevulder approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juadk juadk force-pushed the improve_upgrade_ui_tests branch 3 times, most recently from 50ed5d6 to 7e80a88 Compare October 30, 2023 09:39
@juadk juadk force-pushed the improve_upgrade_ui_tests branch from 7e80a88 to f6fb3f8 Compare October 30, 2023 10:53
@juadk juadk merged commit 76836ff into main Oct 30, 2023
@juadk juadk deleted the improve_upgrade_ui_tests branch October 30, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder approved these changes

Assignees

@juadk juadk

Labels
kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juadk @ldevulder