Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManagedOS upgrade command is hardcoded #59

Closed
Tracked by #58
mudler opened this issue Mar 18, 2022 · 0 comments · Fixed by #66
Closed
Tracked by #58

ManagedOS upgrade command is hardcoded #59

mudler opened this issue Mar 18, 2022 · 0 comments · Fixed by #66
Assignees
@mudler
Labels
area/elemental kind/enhancement New feature or request

Comments

@mudler
Copy link
Contributor

mudler commented Mar 18, 2022 •
edited
Loading

Currently os2 applies Plans from ManagedOS resources in a hardcoded way: https://github.com/rancher-sandbox/os2/blob/9fed2edefc12cbcb426874db137631f9d52de3cd/pkg/controllers/managedos/template.go#L138 .
This doesn't make possible to reuse the ManagedOS resource outside the os2 context, and doesn't allow much flexibility if someone wants to customize the upgrade process.

What we could have instead is exposing the ContainerSpec in suc and if empty fallback to current as defaults. In that way will be easier later to create a OSUpgradeCatalog of ContainerSpecs based on the os2 derivative
@mudler mudler added kind/enhancement New feature or request area/elemental ros-operator need/discussion Issues that needs reviewed and are still untriaged by the team and removed need/discussion Issues that needs reviewed and are still untriaged by the team labels Mar 18, 2022
@mudler mudler mentioned this issue Mar 23, 2022
Closed
14 tasks
@mudler mudler changed the title ManagedOS upgrade command is hardcoded ManagedOS upgrade command is hardcoded Mar 23, 2022
@mudler mudler self-assigned this Mar 23, 2022
mudler added a commit that referenced this issue Mar 23, 2022
@mudler
Allow to specify a upgradeContainerSpec on ManagedOS
661dfd3 
#59

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler linked a pull request Mar 23, 2022 that will close this issue
Add upgradeContainerSpec to ManagedOS and update wrangler #66
Merged
mudler added a commit that referenced this issue Mar 23, 2022
@mudler
Add upgradeContainerSpec to ManagedOS and update wrangler (#66)
b1331ab 
* Allow to specify a upgradeContainerSpec on ManagedOS

#59

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Run go generate and update wrangler

Also pin golang.org/x/tools to latest, to workaround
golang/go#37617

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Update docs

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Adapt to new wrangler signal context

rancher/wrangler@9460166

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Fixup license headers

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler pushed a commit that referenced this issue Jun 3, 2022
Add upgrade command (#59)
b6e6413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mudler mudler

Labels
area/elemental kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add upgradeContainerSpec to ManagedOS and update wrangler rancher/elemental
1 participant
@mudler