Support GPT on legacy BIOS system #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add argument `--force-gpt` to cos-installer to force GPT partition scheme on legacy BIOS system. GRUB has support on this.
mudler
suggested changes
Oct 5, 2021
There was a problem hiding this comment.
It looks good to me, however it needs a version bump into the installer definition file here: https://github.com/rancher-sandbox/cOS-toolkit/blob/master/packages/installer/definition.yaml#L3. Otherwise there is no new installer version with your changes included (and neither CI will see them).
I'd suggest a version: "0.18"
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler
approved these changes
Oct 5, 2021
|
Thank you so much @mudler! |
|
has harvester support GPT as default within 0.30 release？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason behind this PR is that we have users running on legacy BIOS systems with storage greater than MBR limit (2.2TB), so we need to create GPT for their system.
Some additional thoughts: I'm thinking maybe GPT should be the default option, regardless of booting from EFI or Legacy BIOS, because GRUB can use GPT for both. Maybe MBR is the one that should be
--forced, only when users encountered some issue.