Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define layout with yaml format #2068

Conversation

davidcassany
Copy link
Contributor

No description provided.

@davidcassany davidcassany requested a review from a team as a code owner May 7, 2024 14:03
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the set_layout_with_mount_spec_layout_format branch from df0ead2 to 335e7fd Compare May 7, 2024 14:05
@davidcassany davidcassany added the kind/enhancement New feature or request label May 8, 2024
@davidcassany
Copy link
Contributor Author

Using the yaml format instead of the environment variables makes the configuration more explicit. Even in this case it mostly assumes all defaults. In fact I am wondering if the actual defaults are actually appropriate, probably would be better having them as part of the default yaml so they are explicit somwhere.

@davidcassany davidcassany merged commit c95aa38 into rancher:main May 8, 2024
16 of 17 checks passed
@davidcassany davidcassany deleted the set_layout_with_mount_spec_layout_format branch May 8, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants