Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty mount paths #2036

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Remove empty mount paths #2036

merged 1 commit into from
Mar 28, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Mar 28, 2024

When running mount command with a layout file that contains spaces, those spaces will be converted to empty paths.

This commit removes those paths in the Sanitize method for the MountSpec.

Fixes #2035

When running mount command with a layout file that contains spaces,
those spaces will be converted to empty paths.

This commit removes those paths in the Sanitize method for the
MountSpec.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon requested a review from a team as a code owner March 28, 2024 09:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.36%. Comparing base (d993113) to head (9cbe4bc).
Report is 126 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
+ Coverage   72.33%   72.36%   +0.02%     
==========================================
  Files          76       76              
  Lines        9013     9021       +8     
==========================================
+ Hits         6520     6528       +8     
  Misses       1949     1949              
  Partials      544      544              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I wonder if we should issue a warning, as a user I'd like to know, but this can also be fixed silently as does have no impact.

@frelon frelon merged commit 8a67d52 into rancher:main Mar 28, 2024
17 checks passed
@frelon frelon deleted the fix-empty-mount-path branch March 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent paths are mounted read-only
3 participants