Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/canonical/go-efilib #2019

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update github.com/canonical/go-efilib #2019

merged 1 commit into from
Mar 22, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Mar 20, 2024

No description provided.

@frelon frelon requested a review from a team as a code owner March 20, 2024 14:50
@frelon frelon marked this pull request as draft March 20, 2024 14:54
@frelon frelon marked this pull request as ready for review March 21, 2024 09:41
@frelon frelon enabled auto-merge (squash) March 21, 2024 09:43
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.34%. Comparing base (cd97d5c) to head (3925309).

Files Patch % Lines
pkg/efi/types.go 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2019   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files          76       76           
  Lines        8992     8992           
=======================================
  Hits         6505     6505           
  Misses       1944     1944           
  Partials      543      543

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidcassany
davidcassany approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, we already missed many releases in between of that library and comes with a bump on few others.

LGTM

@frelon frelon force-pushed the update-efilib branch 5 times, most recently from 3925309 to a792058 Compare March 22, 2024 13:33
@frelon
Update github.com/canonical/go-efilib
8ad65d0 
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon merged commit 24e2c8f into rancher:main Mar 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frelon @codecov-commenter @davidcassany