Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting to log message #1948

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 9, 2024

Some logging missing the f-suffix when writing formatted logs.

@frelon frelon requested a review from a team as a code owner February 9, 2024 12:13
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Some logging missing the f-suffix when writing formatted logs.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon force-pushed the fix-state-logging branch from 1607a36 to b9591c8 Compare February 9, 2024 12:38
@frelon frelon enabled auto-merge (rebase) February 9, 2024 12:38
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f3d8258) 72.05% compared to head (b9591c8) 72.04%.
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/build-disk.go 0.00% 1 Missing and 1 partial ⚠️
cmd/mount.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   72.05%   72.04%   -0.02%     
==========================================
  Files          72       72              
  Lines        8022     8019       -3     
==========================================
- Hits         5780     5777       -3     
  Misses       1779     1779              
  Partials      463      463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon merged commit c2714b4 into rancher:main Feb 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants