Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary copy of image tree to tmp folder #1938

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Feb 7, 2024

This commit prevents copying already accessible image trees to a temporary foldery to later on sync it again to the final filesystem image.

Prevents rsyncing twice the root tree for directory and file image sources. This tends to be the case for recovery image deployments, which usually are just a copy of the local active system.

part of #1923

This commit prevents copying already accessible image
trees to a temporary foldery to later on sync it again
to the final filesystem image.

Prevents rsyncing twice the root tree for directory
and file image sources. This tends to be the case for
recovery image deployments, which usually are just a
copy of the local active system.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner February 7, 2024 06:40
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (95290e6) 72.38% compared to head (278af06) 72.54%.

Files Patch % Lines
pkg/elemental/elemental.go 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
+ Coverage   72.38%   72.54%   +0.16%     
==========================================
  Files          72       72              
  Lines        7934     7930       -4     
==========================================
+ Hits         5743     5753      +10     
+ Misses       1720     1710      -10     
+ Partials      471      467       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

@davidcassany davidcassany merged commit 8955a78 into rancher:main Feb 7, 2024
14 checks passed
@davidcassany davidcassany deleted the improve_image_deploy branch February 7, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants