Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign elemental-setup*service files to elemental-toolkit #1898

Closed
wants to merge 2 commits into from
Closed

Assign elemental-setup*service files to elemental-toolkit #1898

wants to merge 2 commits into from

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Jan 5, 2024

Fixes #1896

@kkaempf
Assign elemental-setup*service files to elemental-toolkit
78d7bba 
Fixes #1896

Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf kkaempf requested a review from a team as a code owner January 5, 2024 12:08
@kkaempf
Copy link
Contributor Author

kkaempf commented Jan 5, 2024

I consider this a (temporary ?) workaround. The current handling of .service files in elemental-toolkit is ... strange.

frelon
frelon approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kkaempf kkaempf enabled auto-merge (rebase) January 5, 2024 13:26
@davidcassany
Copy link
Contributor

IMHO we do not need it anymore as we already moved the services from /usr to /etc where user provided data is also expected to appear. To my understanding it could be unexpected having data under /usr (with /usr/local as the exception) that is not owned by any package.

auto-merge was automatically disabled February 27, 2024 20:19

Pull request was closed

@kkaempf kkaempf deleted the issue-1896 branch June 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frelon frelon frelon approved these changes

@anmazzotti anmazzotti anmazzotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None of the elemental-setup-*.service files are owned by a package
4 participants
@kkaempf @davidcassany @frelon @anmazzotti