Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add other example distros #1868

Merged
merged 11 commits into from
Dec 11, 2023
Merged

Add other example distros #1868

merged 11 commits into from
Dec 11, 2023

Conversation

davidcassany
Copy link
Contributor

This PR adds a Fedora based image (blue) and an Ubuntu based image (orange)

@davidcassany davidcassany requested a review from a team as a code owner November 30, 2023 12:45
@davidcassany davidcassany force-pushed the add_other_example_distros branch from bbeb4df to 359d769 Compare November 30, 2023 12:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01154fe) 75.33% compared to head (cac221f) 75.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1868      +/-   ##
==========================================
+ Coverage   75.33%   75.96%   +0.63%     
==========================================
  Files          66       66              
  Lines        6893     6912      +19     
==========================================
+ Hits         5193     5251      +58     
+ Misses       1323     1290      -33     
+ Partials      377      371       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidcassany davidcassany mentioned this pull request Nov 30, 2023
Closed
@frelon
Copy link
Contributor

frelon commented Nov 30, 2023

Awesome work 🚀

@davidcassany davidcassany force-pushed the add_other_example_distros branch from f9ffa04 to 93faeaa Compare November 30, 2023 15:44
@davidcassany davidcassany added all-distros Runs CI for all available example images arm64 Runs CI also for arm64 and removed architecture/arm64 labels Nov 30, 2023
@davidcassany davidcassany force-pushed the add_other_example_distros branch from 93faeaa to 63386a7 Compare November 30, 2023 16:18
@davidcassany
Copy link
Contributor Author

davidcassany commented Nov 30, 2023 •
edited
Loading

Ok this last commit makes the CI to react on arm64 and all-distros labels. If arm64 is added it will trigger, in addition, tests for aarch64 builds. If the label all-distros is included it will trigger all examples in the CI. If both labels are present only SUSE distributions are tested on aarch64 (no blue nor orange).

Full suite of tests is only run for green (openSUSE Leap) flavor on x86_64, all other variants are only testing a subset of the full suite.

@davidcassany davidcassany force-pushed the add_other_example_distros branch 3 times, most recently from 55f448f to e23e406 Compare November 30, 2023 16:30
@davidcassany davidcassany added arm64 Runs CI also for arm64 and removed all-distros Runs CI for all available example images arm64 Runs CI also for arm64 labels Nov 30, 2023
@davidcassany davidcassany force-pushed the add_other_example_distros branch from e23e406 to 3b2342c Compare November 30, 2023 17:43
@davidcassany davidcassany added the all-distros Runs CI for all available example images label Nov 30, 2023
kkaempf
kkaempf reviewed Dec 1, 2023
View reviewed changes
kkaempf
kkaempf reviewed Dec 1, 2023
View reviewed changes
@davidcassany
Adding distro examples
766dcee 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Do not test locales
d99ecdd 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Add gdisk package and slightly optimize Makefile
8c681ff 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Move network configuration to defaults instead of essentials
fa30028 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Enable sshd on TW
62967a6 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Make --part-table and --firmware flags deprecated and only support gp…
03f46c7 
…t and efi values respectively

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Improve testing
83cc0dc 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Adding orange tests in CI
dd7b14a 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the add_other_example_distros branch from b84fc2d to c389083 Compare December 5, 2023 16:01
@davidcassany davidcassany removed the arm64 Runs CI also for arm64 label Dec 5, 2023
@davidcassany
Only run other distros on the CI when 'all-distros' label is present …
8d20f30 
…in the PR

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Workaround yip's systemd-firstboot limitations
8cd4a44 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Fix orange flavor smoke test in CI
cac221f 
Add en_US locale in orange flavor and make sure /etc/default/locale
is not existing at boot.

Signed-off-by: David Cassany <dcassany@suse.com>

Bump orange flavor version to make user systemd-firstboot is available

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the add_other_example_distros branch from c389083 to cac221f Compare December 5, 2023 17:22
@davidcassany davidcassany merged commit 1a1b942 into rancher:main Dec 11, 2023
@davidcassany davidcassany deleted the add_other_example_distros branch December 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkaempf kkaempf kkaempf left review comments

@frelon frelon frelon approved these changes

Assignees
No one assigned
Labels
all-distros Runs CI for all available example images
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidcassany @codecov-commenter @frelon @kkaempf