Drop SLE Micro version refrences from the code #1801
Conversation
.obs/dockerfile/Dockerfile
Outdated
| #!BuildTag: rancher/elemental-builder-image/5.3:latest | ||
| #!BuildTag: rancher/elemental-builder-image/5.3:%VERSION% | ||
| #!BuildTag: rancher/elemental-builder-image/5.3:%VERSION%-%RELEASE% | ||
| #!BuildTag: rancher/elemental-builder-image:latest |
There was a problem hiding this comment.
Hmm, this might fail while we build two versions (like 5.3 and 5.4) in parallel.
We should probably just drop the :latest tag ?!
There was a problem hiding this comment.
Done, we keep latest and also the slemicro version, but it resolves dynamically to 5.3 or 5.4
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
351b8a0 to
25817fa
Compare
Add again SLEMicro version within the repository to be sure we can still make use of the 'latest' tag for each base distro version. Now it will be dynamically computed from project configuration at the expense of increasing _service file complexity in OBS. Signed-off-by: David Cassany <dcassany@suse.com>
bbb26e8 to
a001b9b
Compare
| LABEL org.opencontainers.image.created="%BUILDTIME%" | ||
| LABEL org.opencontainers.image.vendor="SUSE LLC" | ||
| LABEL org.opensuse.reference="%%IMG_REPO%%/rancher/elemental-builder-image/5.3" | ||
| LABEL org.opensuse.reference=$IMAGE_REPO | ||
| LABEL org.openbuildservice.disturl="%DISTURL%" | ||
| LABEL com.suse.supportlevel="techpreview" |
There was a problem hiding this comment.
the supportlevel here is "techpreview": should we bump it to l2 (I don't remember if it really was l2 or something elese 😓 )?
There was a problem hiding this comment.
not sure, this image is not customer facing, this is is just the ISO builder image, the one including elemental to actually call elemental build-iso. This is just part of internal tooling to build the vanilla ISO. This was left as is in purpose.
These are the changes required in this repository for the builds I prepared in here.
Note this changes image and charts URLs, so this is likely to be a breaking change from CI perspective.
Part of rancher/elemental#815