Clean up rsync progress display

[frelon]

The current implementation has a memory leak, use Ticker instead.

Also add --partial, --progress, --human-readable flags to rsync call.

[codecov-commenter]

Codecov Report

Patch coverage: 89.47% and no project coverage change.

Comparison is base (2928cb1) 76.57% compared to head (85de375) 76.58%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1789   +/-   ##
=======================================
  Coverage   76.57%   76.58%           
=======================================
  Files          59       59           
  Lines        5584     5594   +10     
=======================================
+ Hits         4276     4284    +8     
- Misses       1012     1014    +2     
  Partials      296      296           

Impacted Files	Coverage Δ
pkg/utils/common.go	80.05% <89.47%> (-0.01%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[davidcassany]

Looks good to me 👍

[ldevulder]

@frelon just out of curiosity: how Ticker helps to remove/reduce the memory leak?

[frelon]

@ldevulder ran some tests with the different implementation, and it was because I used a break instead of a return in the select, which breaks from the select and causes an infinite loop instead of breaking from the loop:

	stop := make(chan bool)
	go func() {
		for {
			select {
			case <-stop:
				break // <- this should be a return
			case <-time.After(5 * time.Second):
				fmt.Println(message)
			}
		}
	}()

So the Ticker implementation is not needed, but I will keep it since it's already merged!