Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ami publishing #1619

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Drop ami publishing #1619

merged 1 commit into from
Oct 11, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Oct 11, 2022

Not needed anymore, all images were clean up.

Signed-off-by: itxaka igarcia@suse.com

@Itxaka Itxaka requested a review from a team October 11, 2022 07:35
Drop ami publishing
87f0b1c 
Not needed anymore, all images were clean up.

Signed-off-by: itxaka <igarcia@suse.com>
kkaempf
kkaempf approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping code is always good ;-)

@Itxaka
Copy link
Contributor Author

Itxaka commented Oct 11, 2022

Can only see the effect on release so merging already

@Itxaka Itxaka merged commit 17b9867 into rancher:main Oct 11, 2022
@Itxaka Itxaka deleted the drop_aws branch October 11, 2022 07:59
@frelon frelon mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkaempf kkaempf kkaempf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Itxaka @kkaempf