Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to new branding #1466

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Change to new branding #1466

merged 4 commits into from
Jun 1, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Jun 1, 2022

elemental -> elemental-cli
rancher-sandbox -> rancher
cos-toolkit -> elemental-toolkit

Signed-off-by: Itxaka igarcia@suse.com

elemental -> elemental-cli
rancher-sandbox -> rancher
cos-toolkit -> elemental-toolkit

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka Itxaka requested a review from mudler June 1, 2022 09:13
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! there are a couple of links changed from the github repo to the github docs pages that I think slipped in (or was that wanted?)

Itxaka and others added 2 commits June 1, 2022 11:50
Co-authored-by: Francesco Giudici <francesco.giudici@gmail.com>
Co-authored-by: Francesco Giudici <francesco.giudici@gmail.com>
@Itxaka
Copy link
Contributor Author

Itxaka commented Jun 1, 2022

Good catch!

@@ -1,5 +1,5 @@
{{ $package := (.Get "package") }}
{{ $website := ( or (.Get "website") "https://rancher-sandbox.github.io/cos-toolkit-package-browser/find" ) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is not moved

docs/config.toml Outdated
pre = "<i class='fab fa-github'></i>"
post = ""
[[menu.main]]
name = "Browse packages"
weight = 55
url = "https://rancher-sandbox.github.io/cos-toolkit-package-browser/"
url = "https://rancher.github.io/elemental-toolkit-package-browser/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

docs/config.toml Outdated

# Repository configuration (URLs for in-page links to opening issues and suggesting changes)
github_repo = "https://github.com/rancher-sandbox/cOS-toolkit"
github_repo = "github.com/rancher/elemental-toolkit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta try this in a preview, not sure if it wants the URI scheme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, my fault 🤦🏼‍♂️

@@ -5,8 +5,8 @@ The website content it is deployed automatically in the `gh-pages` branch by Git
After cloning the repo (with submodules), just run `make serve` to test the website locally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front README have still some references to cOS-toolkit!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, I been searching for those and could not find. You meant the main root README.md right? 🤣

$> git clone --recurse-submodule https://github.com/rancher-sandbox/cos-toolkit
$> cd cos-toolkit
$> git clone --recurse-submodule https://github.com/rancher/elemental-toolkit
$> cd elemental-toolkit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are here.. care to update it to only make docs-serve ? no need to cd into docs anymore

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka Itxaka requested review from mudler, mjura and fgiudici June 1, 2022 12:21
@Itxaka
Copy link
Contributor Author

Itxaka commented Jun 1, 2022

Also updated the main readme and added the links to the teal falvor as they were missing!

Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mudler
Copy link
Contributor

mudler commented Jun 1, 2022

Seems there was a GHA incident today https://www.githubstatus.com/history - not sure if some of our builds currently queued were affected. I'd say to merge it and fixup later if needed

@Itxaka Itxaka merged commit b13694f into rancher:master Jun 1, 2022
@Itxaka Itxaka deleted the fix_site_build branch June 1, 2022 12:49
@mudler mudler mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants