-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to new branding #1466
Change to new branding #1466
Conversation
elemental -> elemental-cli rancher-sandbox -> rancher cos-toolkit -> elemental-toolkit Signed-off-by: Itxaka <igarcia@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! there are a couple of links changed from the github repo to the github docs pages that I think slipped in (or was that wanted?)
Co-authored-by: Francesco Giudici <francesco.giudici@gmail.com>
Co-authored-by: Francesco Giudici <francesco.giudici@gmail.com>
Good catch! |
docs/layouts/shortcodes/package.html
Outdated
@@ -1,5 +1,5 @@ | |||
{{ $package := (.Get "package") }} | |||
{{ $website := ( or (.Get "website") "https://rancher-sandbox.github.io/cos-toolkit-package-browser/find" ) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is not moved
docs/config.toml
Outdated
pre = "<i class='fab fa-github'></i>" | ||
post = "" | ||
[[menu.main]] | ||
name = "Browse packages" | ||
weight = 55 | ||
url = "https://rancher-sandbox.github.io/cos-toolkit-package-browser/" | ||
url = "https://rancher.github.io/elemental-toolkit-package-browser/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
docs/config.toml
Outdated
|
||
# Repository configuration (URLs for in-page links to opening issues and suggesting changes) | ||
github_repo = "https://github.com/rancher-sandbox/cOS-toolkit" | ||
github_repo = "github.com/rancher/elemental-toolkit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta try this in a preview, not sure if it wants the URI scheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, my fault 🤦🏼♂️
@@ -5,8 +5,8 @@ The website content it is deployed automatically in the `gh-pages` branch by Git | |||
After cloning the repo (with submodules), just run `make serve` to test the website locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front README have still some references to cOS-toolkit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, I been searching for those and could not find. You meant the main root README.md right? 🤣
$> git clone --recurse-submodule https://github.com/rancher-sandbox/cos-toolkit | ||
$> cd cos-toolkit | ||
$> git clone --recurse-submodule https://github.com/rancher/elemental-toolkit | ||
$> cd elemental-toolkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are here.. care to update it to only make docs-serve
? no need to cd into docs anymore
Signed-off-by: Itxaka <igarcia@suse.com>
Also updated the main readme and added the links to the teal falvor as they were missing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Seems there was a GHA incident today https://www.githubstatus.com/history - not sure if some of our builds currently queued were affected. I'd say to merge it and fixup later if needed |
elemental -> elemental-cli
rancher-sandbox -> rancher
cos-toolkit -> elemental-toolkit
Signed-off-by: Itxaka igarcia@suse.com