Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add final repo for local-iso build target #1289

Merged
merged 2 commits into from
May 3, 2022

Conversation

davidcassany
Copy link
Contributor

Fixes #1282

Signed-off-by: David Cassany dcassany@suse.com

@mudler
Copy link
Contributor

mudler commented May 3, 2022

mm wait, this is removing the final-repo at all while we build the local-iso, right? but how it is getting the missing packages that are not built locally?

@davidcassany
Copy link
Contributor Author

mm wait, this is removing the final-repo at all while we build the local-iso, right? but how it is getting the missing packages that are not built locally?

yes good point, see https://github.com/rancher-sandbox/elemental/blob/62b0cfd19fcdf4e059e908ce9b7f861541daef58/cmd/build-iso.go#L112-L123

elemetal build-iso creates a repo list from manifest or from defaults (if no manifest). Then the --repo flag appends to this repository list with priority set to 1 (while default priority in manifest or default repo is 90).

$FINAL_REPO is already the default repository. I guess I forgot to remove it from here when I added all defaults in elemental.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the fix_ci_local-iso_builds branch from a438e22 to 815d568 Compare May 3, 2022 09:24
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mudler mudler added the arm64 label May 3, 2022
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler force-pushed the fix_ci_local-iso_builds branch from 93877bc to ddd5b9c Compare May 3, 2022 12:18
@mudler mudler merged commit d2fcf03 into master May 3, 2022
@mudler mudler deleted the fix_ci_local-iso_builds branch May 3, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

elemental build-iso: wrong repo priority order
2 participants