-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a deps target for CI #1262
Add a deps target for CI #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a little leftover I think
Not sure if this is the right approach. The luet installs might also override system binaries (coming e.g. from RPM). |
I guess this affects building on OBS? How does obs tackles dependency? Not calling luet install, Im sure. Well, we can do something else, keep the make deps as usual, and have a make deps_ci which does what this patch does. Would that work for you @kkaempf ? |
That should work, thanks. |
On second thought I think this a good point. We should limit this to the toolchain we provide in
This is a good point I think it should be considered a bug in our toolchain packages, the luet packages should not interfere with whatever the system provides. However this is hard to solve in a sane way, a common solution would be to set luet packages to install under |
This target will always try to upgrade the packages in the system with latest versions from our repo Signed-off-by: Itxaka <igarcia@suse.com>
ok, this should work, this only runs on our CI and tries to upgrade all packages in the deps. Should be safe enough to run only on our ci while leaving the make deps target untouched so it can be used locally or on OBS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This target will always try to upgrade the packages in the system with
latest versions from our repo
Signed-off-by: Itxaka igarcia@suse.com