Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created date to the ManagedOSVersion common metadata fields #886

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

anmazzotti
Copy link
Contributor

Just to include the newly added created timestamp from: rancher/elemental-channels#64

This is an enabler if we want to display the build date of any image to the end user on the UI.

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti requested a review from a team as a code owner November 28, 2024 12:41
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmazzotti anmazzotti merged commit ad150a8 into rancher:main Nov 28, 2024
8 checks passed
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit: I would consider changing "Created" as a field name with something like "CreationTimestamp" or "CreationDate" / "ReleaseDate"

@anmazzotti
Copy link
Contributor Author

FYI @fgiudici I chose created because it is literally the same field of the image manifest, just converted to Unix time format.

skopeo inspect docker://registry.suse.com/suse/sl-micro/6.1/baremetal-os-container:2.2.0-3.9
{
    "Name": "registry.suse.com/suse/sl-micro/6.1/baremetal-os-container",
    "Digest": "sha256:98ca3c5db564c38ae2f3087b80a916be1b6a0a95154bdc75ef2d9af5f9dcb2e5",
    "Created": "2024-11-26T15:52:23.965935128Z",
.
.
.

@fgiudici
Copy link
Member

FYI @fgiudici I chose created because it is literally the same field of the image manifest, just converted to Unix time format.

skopeo inspect docker://registry.suse.com/suse/sl-micro/6.1/baremetal-os-container:2.2.0-3.9
{
    "Name": "registry.suse.com/suse/sl-micro/6.1/baremetal-os-container",
    "Digest": "sha256:98ca3c5db564c38ae2f3087b80a916be1b6a0a95154bdc75ef2d9af5f9dcb2e5",
    "Created": "2024-11-26T15:52:23.965935128Z",
.
.
.

Oh I see, makes sense... thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants