Block reinstall if crds are still pending to be deleted #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85949e0 to
ed4ad39
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
ed4ad39 to
9465ba7
Compare
anmazzotti
reviewed
Jun 26, 2024
| {{- if $inventoryCRD -}} | ||
| {{- if $inventoryCRD.metadata.deletionTimestamp -}} | ||
| {{- required "CRDs from previous installations are pending to be removed (deletionTimestamp is set). Fully deleting them before (re-)installing is required" "" -}} | ||
| {{- $crds := list |
anmazzotti
approved these changes
Jun 26, 2024
6d72d34 to
e31b17d
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
e31b17d to
d375589
Compare
|
For full reference other approaches were considered at a time by having some pre-delete hook to run a cleanup logic #536 This could be an option to try to automate cleanup of an uninstalling operation, feels a bit hacky and error prone, I would not consider it for now, referencing it here in case we need it. In such case the current PR would still be needed as a sanity check. |
anmazzotti
pushed a commit
to anmazzotti/elemental-operator
that referenced
this pull request
Jun 26, 2024
* Block reinstall if crds are still pending to be deleted Signed-off-by: David Cassany <dcassany@suse.com>
anmazzotti
added a commit
that referenced
this pull request
Jun 27, 2024
* Add managedosversion finalizer (#775) * Implement ManagedOSVersion controller and finalizer Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com> * Remove unused ManagedOSVersion Status Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com> * Block reinstall if crds are still pending to be deleted (#784) Signed-off-by: David Cassany <dcassany@suse.com> --------- Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com> Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #775 reinstalling elemental-operator with helm results in a broken installation. This change is to prevent reinstalling CRDs if there are still instances pending to be deleted.
This will prevent from having silently broken installations. This is the same issue as in #515