Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against k8s v1.27, rancher v2.8.2, and upgrade all test dependendencies #628

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

anmazzotti
Copy link
Contributor

@github-actions github-actions bot added area/tests test related changes area/build build related changes labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f07a038) 53.79% compared to head (9ffd16d) 55.11%.
Report is 6 commits behind head on main.

Files Patch % Lines
controllers/seedimage_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   53.79%   55.11%   +1.31%     
==========================================
  Files          40       40              
  Lines        6073     4930    -1143     
==========================================
- Hits         3267     2717     -550     
+ Misses       2519     1926     -593     
  Partials      287      287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmazzotti anmazzotti marked this pull request as ready for review February 15, 2024 08:51
@anmazzotti anmazzotti requested a review from a team as a code owner February 15, 2024 08:51
@anmazzotti anmazzotti marked this pull request as draft February 15, 2024 09:26
@anmazzotti anmazzotti marked this pull request as ready for review February 15, 2024 09:36
…cies

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, great to bump some old dependencies!

certManagerChartURL: https://charts.jetstack.io/charts/cert-manager-${CERT_MANAGER_VERSION}.tgz

rancherVersion: 2.7.8
rancherVersion: 2.8.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, was trying to find 2.8.1, but I'm guessing it's a typo in the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also confused myself here. :D

@anmazzotti anmazzotti changed the title Test against k8s v1.27, rancher v2.8.1, and upgrade all test dependendencies Test against k8s v1.27, rancher v2.8.2, and upgrade all test dependendencies Feb 15, 2024
@anmazzotti anmazzotti merged commit 6c648b6 into rancher:main Feb 15, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes area/tests test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants