-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CAPI cluster role to helm chart #500
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 51.50% 51.50%
=======================================
Files 41 41
Lines 5551 5551
=======================================
Hits 2859 2859
Misses 2443 2443
Partials 249 249 ☔ View full report in Codecov by Sentry. |
I'm missing a bit of context. In my understanding, the If the |
How to fix existing deployments ? |
Yep, it should as the new resource will be deployed on upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need this in any case to allow Rancher CAPI to support elemental.
Thanks @alexander-demicev !
CAPI controller was moved into a separate pod, previously it was embedded into Rancher. CAPI controller interacts with elemental resources and this migration requires a separate set of RBAC rules for the new CAPI pod, current permissions are limited to the upstream resources and rancher specific objects, elemental CRs are not included. This PR adds a cluster role with required permissions, it will be merged later as an aggregated role with the CAPI controller one.