Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unable to add extension tab to Edit Storage Class page #12886

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Dec 13, 2024

Summary

Fixes #11122

Occurred changes and/or fixed issues

  • Improve extension point for tabs to allow more use cases (also implement a "default" for locationConfig IF there's no mode specified)

Technical notes summary

Areas or cases that should be tested

plugin.addTab(
    TabLocation.RESOURCE_DETAIL,
    { resource: ['persistentvolumeclaim', 'storage.k8s.io.storageclass', 'configmap'] },
    {
      name:       'some-name',
      labelKey:   'generic.comingSoon',
      label:      'some-label',
      weight:     -5,
      showHeader: true,
      tooltip:    'this is a tooltip message',
      component:  () => import('./../../shell/components/BackLink.vue')
    }
  );
  • Check that tabs are added ONLY in detail view mode and that it cover the scenario specified on the issue
  • Check other general uses of the TAB extension point and make sure it works

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.11.0 milestone Dec 13, 2024
@aalves08 aalves08 self-assigned this Dec 13, 2024
…ey are not added to EDIT views as well, unless specified otherwise
@aalves08 aalves08 requested a review from jordojordo December 17, 2024 13:48
@aalves08 aalves08 marked this pull request as ready for review December 17, 2024 13:48
@aalves08 aalves08 merged commit 8698cb8 into rancher:master Dec 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add extension tab to Edit Storage Class page
2 participants