Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Create accessible Menu component #12771

Open
nwmac opened this issue Dec 4, 2024 · 2 comments · May be fixed by #13019
Open

a11y: Create accessible Menu component #12771

nwmac opened this issue Dec 4, 2024 · 2 comments · May be fixed by #13019

Comments

@nwmac
Copy link
Member

nwmac commented Dec 4, 2024

We have several menus in the UI and no common Menu component, e.g.:

  • Locale selector on Login Page
  • Page-level menu on Home Page
  • User Avatar menu
  • ..

We should create a Menu component that is keyboard accessible and shows focus state appropriately.

This can then be placed in to the above places to help address accessibility issues, rather than fixing them multiple times.

Check w3c guidelines for correct behaviour of a menu:

(Note, these seem to be contradictory, so need to make sure we have the correct pattern)

@aalves08
Copy link
Member

aalves08 commented Jan 8, 2025

From my work done on accessibility so far, there are some items to replace after this component is created:

Will keep editing this list as my work on accessibility progresses

@aalves08
Copy link
Member

@rak-phillip found a new v-dropdown, tied to the header work (there's no specific issue, I think):

Image

https://github.com/rancher/dashboard/blob/master/shell/components/nav/WindowManager/ContainerLogs.vue#L622-L661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants