WSL: Add host.docker.internal and host.minikube.internal to containers.
#1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops copying the wsl.conf over from the main WSL distribution, so that we can provide different contents in the main one. Signed-off-by: Mark Yen <mark.yen@suse.com>
This edits /etc/hosts on the main distribution to add entries for host.docker.internal and host.minikube.internal for compatibility. We copy over the /etc/hosts file in the data distribution (which we still ask WSL to generate), and then add lines we need. Note that this doesn't appear to actually affect any containers, as moby uses an internal file to generate /etc/hosts. Signed-off-by: Mark Yen <mark.yen@suse.com>
This forces an --add-host to all created containers to be able to resolve host.docker.internal and host.minikube.internal for compatiblity reasons. Signed-off-by: Mark Yen <mark.yen@suse.com>
Same as the previous commit, but for the Linux proxy. Signed-off-by: Mark Yen <mark.yen@suse.com>
|
Please leave the issue open on merge — still need to handle the containerd backend. |
|
Closing for now — I believe we need to actually spin up a DNS forwarder on the VM to do what we want here. Some of the work will be used, but it shouldn't be merged as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #893. This forces dockerd to write out
/etc/hostsin the containers forhost.docker.internalandhost.minikube.internal, so that they can contact the host (tested by attempting to make an ssh connection and verifying the host key).Note that this will not help with things from the host side (from within Windows, or a different WSL distribution); doing so will require administrative privileges to update
/etc/hostsas seem from Windows.