Fixes cached tokens #252
Merged
Fixes cached tokens #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09cf9a9 to
854369c
Compare
ramsayleung
reviewed
Sep 20, 2021
| /// available or the JSON is malformed). It may return `Ok(None)` if: | ||
| /// | ||
| /// * The read token is expired | ||
| /// * The cached token is disabled in the config |
There was a problem hiding this comment.
It seems you are missing one condition that
/// * Its scopes don't match with the current client
There was a problem hiding this comment.
Whoops, I messed up the docs. Should be fine now
ramsayleung
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes:
prompt_for_user, which failed whenread_token_cachereturned and error. The problem here is that we are expecting an error in case the cache file isn't found (FileNotFoundError). We just want to ignore it, but it used?, which caused an early return. So thematchexpression just acceptsOk(Some())now.read_token_cachefor OAuth clients didn't check the config. WhoopsI also updated the docs to make them more exhaustive.
Motivation and Context
This was caused by #250
Dependencies
None
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
If you remove all cached tokens in your main directory and try to run any example it won't work. Now it does. This is because
prompt_user_tokenreturnedFileNotFoundand propagated. For example try with: