Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayHistory returns FullTrack despite Spotify documentation #139

Merged
merged 2 commits into from
Oct 17, 2020
Merged

PlayHistory returns FullTrack despite Spotify documentation #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9456955
PlayHistory returns FullTrack despite Spotify documentation
aramperes Oct 15, 2020
bfb4440
Update CHANGELOG.md
aramperes Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Renamed environmental variables to `RSPOTIFY_CLIENT_ID`, `RSPOTIFY_CLIENT_SECRET` and `RSPOTIFY_REDIRECT_URI` to avoid name collisions with other libraries that use OAuth2 ([#118](https://github.com/ramsayleung/rspotify/issues/118)).
- Fix typo in `user_playlist_remove_specific_occurrenes_of_tracks`, now it's `user_playlist_remove_specific_occurrences_of_tracks`.
- All fallible calls in the client return a `ClientError` rather than using `failure`.
- Changed type of `track` in `PlayHistory` to `FullTrack` ([#139](https://github.com/ramsayleung/rspotify/pull/139)).

## 0.10 (2020/07/01)

Expand Down
3 changes: 1 addition & 2 deletions src/model/playing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use serde::{Deserialize, Serialize};

use super::context::Context;
use super::track::FullTrack;
use super::track::SimplifiedTrack;
/// Current playing track
/// [get the users currently playing track](https://developer.spotify.com/web-api/get-the-users-currently-playing-track/)
#[derive(Clone, Debug, Serialize, Deserialize)]
Expand All @@ -20,7 +19,7 @@ pub struct Playing {
/// [play history object](https://developer.spotify.com/web-api/object-model/#play-history-object)
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct PlayHistory {
pub track: SimplifiedTrack,
pub track: FullTrack,
pub played_at: DateTime<Utc>,
pub context: Option<Context>,
}