Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to create AuthCodePkceSpotify from token with config #511

Closed
gdesmott opened this issue Dec 28, 2024 · 2 comments · Fixed by #512
Closed

No way to create AuthCodePkceSpotify from token with config #511

gdesmott opened this issue Dec 28, 2024 · 2 comments · Fixed by #512
Labels
enhancement New feature or request

Comments

@gdesmott
Copy link
Contributor

There is currently no way to create AuthCodePkceSpotify with a custom config.

Is there any reason to not have AuthCodePkceSpotify::from_token_with_config() as there is for AuthCodeSpotify?
@gdesmott gdesmott added the enhancement New feature or request label Dec 28, 2024
gdesmott added a commit to gdesmott/rspotify that referenced this issue Dec 29, 2024
@gdesmott
auth_code_pkce: add from_token_with_config() constructor
e457d7f 
This is required to be able to refresh an expired token from the cache
as we need the client ID to refresh the token.

Fix ramsayleung#511
@gdesmott gdesmott mentioned this issue Dec 29, 2024
Merged
1 task
@gdesmott
Copy link
Contributor Author

I think we need this to be able to refresh an expired cached token, see #512

@ramsayleung
Copy link
Owner

The AuthCodePkceSpotify implementation was contributed by another maintainer, so I don't have full context on the reasoning behind not including a from_token_with_config() method, my intuition is he might just miss the requirement of the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

auth_code_pkce: add from_token_with_config() constructor gdesmott/rspotify
2 participants
@gdesmott @ramsayleung