Remove SKU ACS-SN4280 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ram25794 <ssingamala@nvidia.com>
16137bd to
016973e
Compare
Signed-off-by: ram25794 <ssingamala@nvidia.com>
Signed-off-by: ram25794 <ssingamala@nvidia.com>
Signed-off-by: ram25794 <ssingamala@nvidia.com>
Signed-off-by: ram25794 <ssingamala@nvidia.com>
dgsudharsan
approved these changes
Feb 19, 2025
| @@ -1,5 +1,6 @@ | |||
| {# | |||
| Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. | |||
| SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | |||
There was a problem hiding this comment.
@oleksandrivantsiv , As we are adding new symlink to that file , I think Header check is considering it as new file addition and Header check is failing on that file. So , I had to change the copyright information.
oleksandrivantsiv
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Every ACS-.....SKU is expected to have ingress_lossy pool but SKU ACS-SN4280 does not contain it. So removing the ACS SKU to make it compliant.
Work item tracking
How I did it
Removed the symlinks in Mellanox-SN4280-O28 folder and added the required files.
How to verify it
Generated config using Mellanox-SN4280-O28 SKU and tested on the device
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)