-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blob_sidecar type #307
Conversation
the inclusion proof is a SSZ copying here: class BlobSidecar(Container):
index: BlobIndex # Index of blob in block
blob: Blob
kzg_commitment: KZGCommitment
kzg_proof: KZGProof # Allows for quick verification of kzg_commitment
signed_block_header: SignedBeaconBlockHeader
kzg_commitment_inclusion_proof: Vector[Bytes32, KZG_COMMITMENT_INCLUSION_PROOF_DEPTH] It's important for the SSZ serialization and hash tree root that the types match exactly. So you can just import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! we can drop the signed envelope but then this looks g2g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! Nice work :)
Fixes #306.
Note:
kzg_commitment_inclusion_proof
is a vector ofBytes32
in python spec.Do we want it to be an array?
pub kzg_commitment_inclusion_proof = [Bytes32; KZG_COMMITMENT_INCLUSION_PROOF_DEPTH]