-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python3.11 to tests, README detail and bump dependencies #87
Add Python3.11 to tests, README detail and bump dependencies #87
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 45 45
Lines 2153 2153
Branches 164 164
=======================================
Hits 1791 1791
Misses 329 329
Partials 33 33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to add a comment to remind me what I've seen when I come back to give a final review. Changes so far look good, just needs 3.10 & 3.11 CI sorting and the merge conflicts resolving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the issue with calling login()
multiple places, just increase the number of minutes the access token is valid for. For GitHub Actions, you can do that at
https://github.com/ral-facilities/operationsgateway-api/blob/DSEGOG-287-Issues-setting-up-dev-environment/.github/ci_config.yml#L26
Looks good otherwise :)
Thanks - nice that this is configurable. I went looking and saw:
And (incorrectly) jumped to the conclusion the lifetime of the token was hardcoded so would have to just spam login or refresh requests. Though thinking about it for any significant amount of time should've seen that 604800 is a week in seconds so can't have been anything to do with a token expiring after an hour...
|
Changes
motor
andorjson