Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsegog 369 migrate to python 3.11 #147

Merged
merged 19 commits into from
Feb 3, 2025

Conversation

moonraker595
Copy link
Contributor

@moonraker595 moonraker595 commented Nov 27, 2024

The dev server currently uses Rocky 8 with the API running Python 3.8.

Migrating the dev server to Rocky 9 means updating to Python 3.9 as it doesn’t come with 3.8.

We might as well migrate the code base and associated setup to Python 3.11 to save doing it later.

This PR makes the necessary code changes to get the API running, and tested on 3.11.

The main issue has been getting the tests to run given a newer version of matplotlib, which includes some aliases. These have been excluded from the test as they are the same as the existing ones.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (8ba1a40) to head (d465310).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #147    +/-   ##
========================================
  Coverage   95.67%   95.67%            
========================================
  Files          73       73            
  Lines        3765     3766     +1     
  Branches      387      659   +272     
========================================
+ Hits         3602     3603     +1     
  Misses        113      113            
  Partials       50       50            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kevinphippsstfc kevinphippsstfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doing a search for 3.8 across the repo I found that there is a reference to 3.8, 3.9, 3.10 in the docs/github_actions.md file so that paragraph could do with updating as we do not have that complication any more.

README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
moonraker595 and others added 2 commits January 28, 2025 09:31
Co-authored-by: patrick-austin <61705287+patrick-austin@users.noreply.github.com>
@moonraker595
Copy link
Contributor Author

moonraker595 commented Jan 28, 2025 via email

Copy link
Contributor

@patrick-austin patrick-austin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have only reviewed the changes since Kevin's last review (24e0651 onward) and these look fine and address the comments so approving.

@moonraker595 moonraker595 requested review from kevinphippsstfc and removed request for kevinphippsstfc February 3, 2025 13:48
@moonraker595 moonraker595 merged commit ad8f996 into main Feb 3, 2025
6 checks passed
@moonraker595 moonraker595 deleted the DSEGOG-369-Migrate-to-Python-3.11 branch February 3, 2025 15:53
louise-davies added a commit to ral-facilities/operationsgateway that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants