Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number_of_spares field to catalogue items #416

Closed
3 tasks done
joelvdavies opened this issue Nov 8, 2024 · 1 comment · Fixed by #426
Closed
3 tasks done

Add number_of_spares field to catalogue items #416

joelvdavies opened this issue Nov 8, 2024 · 1 comment · Fixed by #426
Assignees
@joelvdavies
Labels
enhancement New feature or request

Comments

@joelvdavies
Copy link
Collaborator

joelvdavies commented Nov 8, 2024 •
edited
Loading

This should

  • Default to None
  • Only be in the database model and get schemas - it should not be possible to set it on creation/edits (it will be calculated later)
  • Include a migration to add the field to all existing catalogue items (Again defaulting to None)

This is a simpler approach than the alternative of having the field non-optional at which point we would need the migration to also know the spares definition at the time of execution and would need all item creation requests to be blocked by the spares definition if it is not assigned.
@joelvdavies joelvdavies added the enhancement New feature or request label Nov 8, 2024
@joelvdavies joelvdavies changed the title Add spare field to catalogue items Add spares field to catalogue items Nov 8, 2024
@joelvdavies joelvdavies mentioned this issue Nov 8, 2024
Open
7 tasks
@joelvdavies joelvdavies changed the title Add spares field to catalogue items Add number_of_spares field to catalogue items Nov 22, 2024
@joelvdavies
Copy link
Collaborator Author

joelvdavies commented Nov 22, 2024 •
edited
Loading

Updated name as spares implied it contained a list of actual spares not just the number of spares.

@joelvdavies joelvdavies self-assigned this Nov 25, 2024
@joelvdavies joelvdavies moved this from Backlog to In Progress in Inventory Management System Nov 25, 2024
joelvdavies added a commit that referenced this issue Nov 25, 2024
@joelvdavies
Add number_of_spares field to catalogue items #416
6af77e0
@joelvdavies joelvdavies mentioned this issue Nov 25, 2024
Merged
3 tasks
joelvdavies added a commit that referenced this issue Nov 25, 2024
@joelvdavies
Update unit and e2e tests to include number_of_spares #416
f9e7810
@joelvdavies joelvdavies moved this from In Progress to In Review in Inventory Management System Nov 25, 2024
joelvdavies added a commit that referenced this issue Nov 27, 2024
@joelvdavies
Merge branch 'develop' into add-spares-field-#416
552046b
joelvdavies added a commit that referenced this issue Nov 27, 2024
@joelvdavies
Merge branch 'add-spares-field-#416' into improve-migration-script-#425
8362311
joelvdavies added a commit that referenced this issue Dec 4, 2024
@joelvdavies
Merge branch 'develop' into add-spares-field-#416
26d9636
joelvdavies added a commit that referenced this issue Dec 4, 2024
@joelvdavies
Address review comments #416
d549b92
joelvdavies added a commit that referenced this issue Dec 4, 2024
@joelvdavies
Merge branch 'add-spares-field-#416' into handle-property-migration-c…
b26a36e 
…onflict-#412
joelvdavies added a commit that referenced this issue Dec 4, 2024
@joelvdavies
Merge branch 'add-spares-field-#416' into improve-migration-script-#425
918b0f6
joelvdavies added a commit that referenced this issue Dec 5, 2024
@joelvdavies
Merge branch 'develop' into add-spares-field-#416
b742092
joelvdavies added a commit that referenced this issue Dec 5, 2024
@joelvdavies
Merge branch 'add-spares-field-#416' into improve-migration-script-#425
e31b39c
joelvdavies added a commit that referenced this issue Dec 5, 2024
@joelvdavies
Merge branch 'add-spares-field-#416' into handle-property-migration-c…
6ea19b6 
…onflict-#412
joelvdavies added a commit that referenced this issue Dec 5, 2024
@joelvdavies
Merge pull request #426 from ral-facilities/add-spares-field-#416
165c603 
Add `number_of_spares` field to catalogue items #416
@github-project-automation github-project-automation bot moved this from In Review to Done in Inventory Management System Dec 5, 2024
@VKTB VKTB moved this from Done to Archive in Inventory Management System Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelvdavies joelvdavies

Labels
enhancement New feature or request
Projects
Inventory Management System
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add number_of_spares field to catalogue items #416 ral-facilities/inventory-management-system-api
1 participant
@joelvdavies