Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ilike operator for case insensitive searching #891

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

MRichards99
Copy link
Contributor

@MRichards99 MRichards99 commented Oct 28, 2021

Description

This PR will close #731

This is just a search and replace PR to support case insensitive searching on ICAT instances that use Oracle DB (i.e. production).

I will make this 'ready to review' once Python ICAT 0.20.0 has been released and ral-facilities/datagateway-api#273 has been merged.

Testing instructions

Check that all instances of the like operator have been changed to ilike. I could only find instances of this operator in datagateway-common.

Test that filters etc. haven't been broken by this change

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

connect to #731

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #891 (8534879) into master (7795715) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         121      121           
  Lines        5974     5974           
  Branches     1666     1666           
=======================================
  Hits         5883     5883           
  Misses         87       87           
  Partials        4        4           
Flag Coverage Δ
common 98.62% <ø> (ø)
dataview 98.62% <ø> (ø)
download 97.48% <ø> (ø)
search 98.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/datagateway-common/src/api/index.tsx 95.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7795715...8534879. Read the comment docs.

@MRichards99
Copy link
Contributor Author

As this issue only affects production ICATs, I have just tested this by spinning up a local DataGateway by using ISIS prod config pointing at my local DataGateway API which also points at ISIS prod. You can see this works on the right (my local instance) whereas it doesn't work on the left (current deployment of DataGateway ISIS, without this fix).

image

@MRichards99
Copy link
Contributor Author

The CI failure on DataView e2e tests will be fixed once ral-facilities/datagateway-api#273 has been merged.

@MRichards99 MRichards99 marked this pull request as ready for review November 2, 2021 17:23
@MRichards99
Copy link
Contributor Author

Making ready to review as the work on the API has been merged. I will re-run the CI on this PR to see if the DataView failures disappear.

Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out locally - it's great that this has been fixed 😁

@MRichards99 MRichards99 merged commit 92ce8f9 into master Nov 3, 2021
@MRichards99 MRichards99 deleted the bugfix/case-insensitive-search-#731 branch November 3, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrument search is case-sensitive
2 participants