Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libgconf install step on CI jobs #1692

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

louise-davies
Copy link
Member

Description

Github changed the default machine from Ubuntu 22 to Ubuntu 24, which doesn't have libgconf-2-4. Equally, Cypress no longer needs this dependency so it can just be removed

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@louise-davies louise-davies added the bug Something isn't working label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (44b11eb) to head (a0585dc).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1692   +/-   ##
========================================
  Coverage    95.39%   95.39%           
========================================
  Files          183      183           
  Lines         7932     7932           
  Branches      2516     2510    -6     
========================================
  Hits          7567     7567           
  Misses         330      330           
  Partials        35       35           
Flag Coverage Δ
common 94.27% <ø> (ø)
dataview 97.32% <ø> (ø)
download 96.03% <ø> (ø)
search 93.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies merged commit 20091c4 into develop Jan 9, 2025
10 checks passed
@louise-davies louise-davies deleted the fix-ci-libgconf branch January 9, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant