-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db creation script #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't run the script:
Traceback (most recent call last):
File "util/icat_db_generator.py", line 9, in <module>
from common.models import db_models
ModuleNotFoundError: No module named 'common'
I've tried running it in utils
as well as running it in common
I had this issue only when I ran it through git bash. It ran fine with powershell. Is it possible this is similar to the issue you have with the tests @louise-davies |
This is on the preprod machine, so it is using bash but native bash. The preprod machine can run the test command fine. |
Ok. I'll take a look |
@louise-davies I have updated the instructions. It turns out that you need to use |
util/icat_db_generator.py
Outdated
session.close() | ||
|
||
|
||
def get_time_now(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this function if it no longer gets the current time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed and changed the range of dates from 2000-2019 to give a nicer range that matches more closely the other possible dates for other fields.
closes #70