Fix GitHub Actions Errors #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 40 40
Lines 3375 3375
Branches 317 317
=======================================
Hits 3267 3267
Misses 80 80
Partials 28 28 ☔ View full report in Codecov by Sentry. |
Merged
6 tasks
MRichards99
reviewed
Jun 9, 2023
ad8fa9c to
be37a71
Compare
I honestly have no idea why the coverage decreased by 2%. I spent some time looking at this but could not work it out. |
|
@MRichards99 Looks okay now. It updated after the CI ran again. |
MRichards99
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes all the GitHub Action-related errors (https://github.com/ral-facilities/datagateway-api/actions/runs/5146527468). Also ignores the
werkzeugvulnerability as the fix for this requires Python 3.7 or above.Testing Instructions
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?