Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax codecov checks #419

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Relax codecov checks #419

merged 1 commit into from
Jun 16, 2023

Conversation

MRichards99
Copy link
Collaborator

Description

A small change to relax codecov checks so they don't fail so often - hopefully this means that when they do fail, we actually pay attention to them! The config matches that on SciGateway (see https://github.com/ral-facilities/scigateway/blob/develop/codecov.yml).

I've checked the config is valid by following the instructions at https://docs.codecov.com/docs/codecov-yaml#validate-your-repository-yaml

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

- These checks match the checks that happen on SciGateway
@MRichards99 MRichards99 requested a review from VKTB April 25, 2023 14:38
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9921b53) 96.84% compared to head (65f9a39) 96.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          40       40           
  Lines        3363     3363           
  Branches      316      316           
=======================================
  Hits         3257     3257           
  Misses         78       78           
  Partials       28       28           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MRichards99 MRichards99 linked an issue Apr 25, 2023 that may be closed by this pull request
2 tasks
@MRichards99 MRichards99 merged commit 34a2662 into main Jun 16, 2023
@MRichards99 MRichards99 deleted the relax-codecov-checks branch June 16, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax Codecov PR Checks
2 participants