Remove outdated paragraph on constraints on the setuptools version #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is no longer needed as Python ICAT 1.0 is now used, which doesn't require an older version of setuptools
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 96.84% 96.80% -0.05%
==========================================
Files 40 40
Lines 3363 3375 +12
Branches 316 317 +1
==========================================
+ Hits 3257 3267 +10
- Misses 78 80 +2
Partials 28 28 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Good spot! I've removed references to this on our GitHub Actions as we don't need to uninstall & reinstall setuptools, which will speed up the CI times. GitHub Actions has passed so I'll merge this PR |
MRichards99
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggest to remove an outdated paragraph from the README: according to
pyproject.tomlyou are requiringpython-icat = "1.0.0". This version dropped support for Python 2 and does not use2to3any more. So there is no (known) constraint on thesetuptoolsversion in currentpython-icat.Testing Instructions
No code changes, only documentation update.