Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GitHub Actions warnings #406

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

VKTB
Copy link
Contributor

@VKTB VKTB commented Feb 27, 2023

This PR will close #397

Description

  • Addresses the warnings by GitHub Actions in the ci-build.yml and release-build.yml workflows
  • Updates and pins actions to commit SHAs in the ci-build.yml and release-build.yml workflows
  • Configures Dependabot to check and open new PRs when new action versions are released

I am not sure how the relekang/python-semantic-release Action works but it's currently pinned to master and we should not do this. When I search for this action in Google, I get results for python-semantic-release. Are they the same? If they are then I am guessing we can update the usage of relekang/python-semantic-release@master in release-build.yml to python-semantic-release/python-semantic-release@bfa503c3ef98d240a6d9cb09a8a8603e84200b42 # v7.33.2.

Testing Instructions

  • Review code
  • Check GitHub Actions build

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c06b4d) 96.84% compared to head (53a6993) 96.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          40       40           
  Lines        3363     3363           
  Branches      316      316           
=======================================
  Hits         3257     3257           
  Misses         78       78           
  Partials       28       28           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VKTB VKTB requested a review from MRichards99 February 28, 2023 10:21
@MRichards99
Copy link
Collaborator

@VKTB It looks like relekang/python-semantic-release redirects to https://github.com/python-semantic-release/python-semantic-release so I'd go ahead and make that change

@VKTB VKTB force-pushed the fix/address-github-actions-warnings-#397 branch from 9d34786 to 200d842 Compare March 17, 2023 10:32
@VKTB
Copy link
Contributor Author

VKTB commented Mar 17, 2023

@VKTB It looks like relekang/python-semantic-release redirects to https://github.com/python-semantic-release/python-semantic-release so I'd go ahead and make that change

Addressed this so it is now ready for review.

Copy link
Collaborator

@MRichards99 MRichards99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Python semantic release doesn't work as expected, let me know and we can have a look at it together

@VKTB VKTB merged commit 5807986 into main Apr 6, 2023
@VKTB VKTB deleted the fix/address-github-actions-warnings-#397 branch April 6, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address warnings in Actions CI
2 participants