Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove dataset filesize #403

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

Reillyhewitson
Copy link
Contributor

This PR will close #{issue number}

Description

This removes the dataset filesize generation step to ensure that the new database triggers are used to generate filesizes.

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Connect to #{issue number}

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 96.89% // Head: 96.89% // No change to project coverage 👍

Coverage data is based on head (5dce490) compared to base (4b121d6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          39       39           
  Lines        3319     3319           
  Branches      310      310           
=======================================
  Hits         3216     3216           
  Misses         76       76           
  Partials       27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VKTB VKTB mentioned this pull request Feb 23, 2023
6 tasks
@Reillyhewitson Reillyhewitson merged commit d530145 into main Feb 23, 2023
@Reillyhewitson Reillyhewitson deleted the fix/remove-dataset-filesize branch February 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants