Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError when trying to run DG API on its own #346

Merged

Conversation

VKTB
Copy link
Contributor

@VKTB VKTB commented Feb 25, 2022

This PR will close #345

Testing Instructions

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • DG API can run on its own

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #346 (7479cc3) into master (60a599e) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   94.45%   94.42%   -0.03%     
==========================================
  Files          39       39              
  Lines        3065     3067       +2     
  Branches      306      307       +1     
==========================================
+ Hits         2895     2896       +1     
  Misses        144      144              
- Partials       26       27       +1     
Impacted Files Coverage Δ
datagateway_api/src/common/filter_order_handler.py 98.61% <80.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a599e...7479cc3. Read the comment docs.

@VKTB VKTB marked this pull request as ready for review February 25, 2022 14:22
@VKTB VKTB requested a review from MRichards99 February 25, 2022 14:22
@VKTB VKTB merged commit 9cc9cdb into master Feb 28, 2022
@VKTB VKTB deleted the bugfix/attribute-error-when-running-DG-API-on-its-own-#345 branch February 28, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when trying to run DG API on its own
2 participants