Fix failing Nox tests session on Windows #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 43 43
Lines 3216 3216
Branches 321 321
=======================================
Hits 2981 2981
Misses 198 198
Partials 37 37 Continue to review full report at Codecov.
|
|
From GitHub Actions |
MRichards99
requested changes
Feb 17, 2022
noxfile.py
Outdated
| @@ -95,6 +95,8 @@ def tests(session): | |||
| # version didn't fix the `2to3` issue when building Python ICAT, perhaps because | |||
| # Python ICAT isn't built on the downgraded version for some reason? | |||
| session.run("poetry", "run", "pip", "uninstall", "-y", "setuptools") | |||
There was a problem hiding this comment.
For consistency, you might as well remove the poetry run from the uninstall - I did this on my machine without issue
There was a problem hiding this comment.
Good point, I removed it.
…-facilities/datagateway-api into fix-nox-test-session-on-windows-#307
MRichards99
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #307
Description
Fixes the failing
noxtestssession on Windows.Testing Instructions
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?noxtestssession should not failsetuptoolsshould be<58.0.0