Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default DataGateway API Backend to Python ICAT #334

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

VKTB
Copy link
Contributor

@VKTB VKTB commented Feb 17, 2022

This PR will close #318

Description

Setting Python ICAT as the default backend since that is the backend that is used in production.

Testing Instructions

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #334 (f15522f) into master (11d59e8) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   92.62%   92.69%   +0.06%     
==========================================
  Files          43       43              
  Lines        3215     3216       +1     
  Branches      321      321              
==========================================
+ Hits         2978     2981       +3     
  Misses        198      198              
+ Partials       39       37       -2     
Impacted Files Coverage Δ
datagateway_api/src/search_api/helpers.py 97.46% <0.00%> (-2.54%) ⬇️
...gateway_api/src/search_api/query_filter_factory.py 95.23% <0.00%> (-0.32%) ⬇️
datagateway_api/src/common/config.py 100.00% <0.00%> (ø)
...agateway_api/src/resources/search_api_endpoints.py 100.00% <0.00%> (ø)
datagateway_api/src/api_start_utils.py 86.29% <0.00%> (+0.45%) ⬆️
datagateway_api/src/search_api/models.py 98.50% <0.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d59e8...f15522f. Read the comment docs.

@VKTB VKTB marked this pull request as ready for review February 17, 2022 13:07
@VKTB VKTB requested a review from MRichards99 February 17, 2022 13:07
@VKTB VKTB merged commit 8d2264d into master Feb 17, 2022
@VKTB VKTB deleted the change-default-dg-api-backend-#318 branch February 17, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Default DataGateway API Backend to Python ICAT
2 participants